3.2 & 3.3 Extensions Database 3.2 / 3.3 ⇒ Who Visited This Topic

[BBBenj]

Hello,

First of all, thank you for that wonderful job.

I customized that extension in order to show more than the 255 last viewers (quite easy in fact), I modified the information on screen, adding last visit time, but I have one request: instead of showing the max number of viewers as decided in ACP, is it possible to use the real number of viewers, please?

As I really don't mind to know how many "viewers" the admin (me ) authorized, but the real number of viewers... I used to have this number with the mod on 3.0.x version of phpBB.

Can you do something for me, please?

[dmzx]

is it possible to use the real number of viewers, please?

What do you mean exactly?

[BBBenj]

Hi,

First of all, thanks for your answer.

What I want is to know how many unique visitors came to a given topic, with their names, the number of times they came here and when they came last time.

In fact, your extension is nearly perfect for me, except that it doesn't give me the total number of visitors, but a number I specified in the ACP.

Have I been clear enough?

[ Post made via Android ]

[dmzx]

Hi,

First of all, thanks for your answer.

What I want is to know how many unique visitors came to a given topic, with their names, the number of times they came here and when they came last time.

In fact, your extension is nearly perfect for me, except that it doesn't give me the total number of visitors, but a number I specified in the ACP.

Have I been clear enough?

[ Post made via Android ]

So you want "Total visits" also shown?
Just a counter you mean?

[Scanialady]

The problem seems to be fixed. Members without Avatar get the prosilver no_avatar.gif now. Nobody received a new password popup.

Thank you :-)

... and now the problem seems to be there again. I installed the new (CDB)-Version yesterday night. Now the popup with admin login comes again if users with no avatar has visited a topic.

Who Visited This Topic

Because you have changed the code: how to solve this now?

[dmzx]

The problem seems to be fixed. Members without Avatar get the prosilver no_avatar.gif now. Nobody received a new password popup.

Thank you :-)

... and now the problem seems to be there again. I installed the new (CDB)-Version yesterday night. Now the popup with admin login comes again if users with no avatar has visited a topic.

Who Visited This Topic

Because you have changed the code: how to solve this now?

Change the line again to test it.

'AVATAR' => empty($avatar) ? '<img src="' . $this->root_path . 'styles/prosilver/theme/images/no_avatar.gif" width="60px;" height="60px;" alt="" />' : $avatar,

[Scanialady]

If I change the linked Line 248 of listener.php from $user_id = (int) $member['user_id'];

to

'AVATAR' => empty($avatar) ? '<img src="' . $this->root_path . 'styles/prosilver/theme/images/no_avatar.gif" width="60px;" height="60px;" alt="" />' : $avatar,

I get a 500 error.

server error log something like this

Code: Select all

mod_fcgid: stderr: PHP Parse error:  syntax error, unexpected '=>' (T_DOUBLE_ARROW) in /home/...ladyscommunity.de/public_html/ext/dmzx/whovisitedthistopic/event/listener.php on line 248
mod_fcgid: stderr: PHP Parse error:  syntax error, unexpected '=>' (T_DOUBLE_ARROW) in /home/...ladyscommunity.de/public_html/ext/dmzx/whovisitedthistopic/event/listener.php on line 248
mod_fcgid: stderr: PHP Parse error:  syntax error, unexpected '=>' (T_DOUBLE_ARROW) in /home/...ladyscommunity.de/public_html/ext/dmzx/whovisitedthistopic/event/listener.php on line 248, referer: http://forum.ladyscommunity.de/index.php
mod_fcgid: stderr: PHP Parse error:  syntax error, unexpected '=>' (T_DOUBLE_ARROW) in /home/...ladyscommunity.de/public_html/ext/dmzx/whovisitedthistopic/event/listener.php on line 248, referer: http://forum.ladyscommunity.de/index.php

[dmzx]

No

Check the template variable line https://github.com/dmzx/Who-Visited-Thi ... r.php#L227

Change that line.

[martin]

Why not just give each group a default avatar in acp then the problem wont ever happen also with other ext's.

[Scanialady]

changed code, as I said...

Ok, line 227
'AVATAR' => empty($avatar) ? '<img src="' . $this->phpbb_admin_path . 'images/no_avatar.gif" width="60px;" height="60px;" alt="" />' : $avatar,
looks better. I changed to
'AVATAR' => empty($avatar) ? '<img src="' . $this->root_path . 'styles/prosilver/theme/images/no_avatar.gif" width="60px;" height="60px;" alt="" />' : $avatar,
and cleared the caches. No error, and the problem seems to be solved again :) Thanks.

Why not just give each group a default avatar in acp then the problem wont ever happen also with other ext's.

a good idea, martin - and my groups HAVE default avatars. But sometimes the avatar is deleted and no new was set. On my little board I can find it in seconds - If I would have 5000 members it would be a problem :)
This error was in the dev version before - if this version shall be the CDB version it should be solved. (Has everybody prosilver installed? we hope so)

[BBBenj]

Hi,

First of all, thanks for your answer.

What I want is to know how many unique visitors came to a given topic, with their names, the number of times they came here and when they came last time.

In fact, your extension is nearly perfect for me, except that it doesn't give me the total number of visitors, but a number I specified in the ACP.

Have I been clear enough?

[ Post made via Android ]

So you want "Total visits" also shown?
Just a counter you mean?

Exactly!! Just that.

[Kinsman]

There is a clash between this and relative time. The Relative Time extension has a public function to turn it off, but I'm unsure how to add it?

https://github.com/senky/phpbb-ext-rela ... me.php#L69

[Kinsman]

Actually this seems to be the fix, it allows other extensions to ignore the mouseover. Any chance it could be added?

https://github.com/Senky/phpbb-ext-rela ... a437b3a1c7

[Kinsman]

No love? Ah well I guess I will just delete the date part of this for now.

[dmzx]

Will check it.