3.2 & 3.3 Extensions Database 3.2 / 3.3 ⇒ Editor extension

[admin1]

When I am installing this extension though Upload Extensions in ACP am getting this message

Code: Select all

composer.json wasn’t found in the uploaded zip file. The file was not saved on the server.

any idea ?

[ivailo95]

Delete Editor extension from data base and ur board after did that,please install without useing upload ext

[picaron]

I firmly believe that the use of this extension and the extensions that rely on it, are reckless for administrators who have a low-medium level of phpBB.

You should VERY CLEARLY NOTICE that this extension MODIFIES files of the phpBB core and should inform about the method or package that should be used when updating the forum.

A wrong choice of the phpBB update package can lead to the total crash of the forum using this extension.

Even so, I recognize that the idea of the extension is ingenious and is very well designed for its purpose.

[martin]

Have a think about what you just said want a hint ?

core files

phpbb update

Now think about 8 years ago with snippets and phpbb updates see the issue in your post yet ?

[picaron]

Martin, I am very sorry that my comment could have made you feel bad.

If an administrator with phpBB 3.3.3 and who has not made any changes to the core of his forum has installed the HTML email v1.0.0 extension, which needs this extension, when updating his forum to 3.3.4 using the full package, if the forum has enabled the user registration option with email notification, it will get a 500 error when a user tries to register.

This is a real case, you can see it here.
https://www.phpbb-es.com/foro/viewtopic ... 25#p248182

I repeat, I feel that my comment is not to your liking, but I insist, you should advise how to update the forum having this extension and those that depend on it and are installed in the forum.

Excuse me for my poor English ...

[Sniper_E]

You have to remember back when we created MODS for phpbb.
In some mods it edited the includes/functions.php, for example, and it was fine.

Now that they have moved to extensions in phpbb, you can not edit a core file to make an old ext work.
With this ext you can now edit core files like we NORMALLY use to do. This extension is fine.

It looks like you are pointing out an error with HTML email v1.0.0 extension in THIS topic.
Go make your point in the correct topic. Or do you have any useful comments on this Editor extension?

[martin]

This ext does not edit core files what it does is make a back up of a file and then replaces that file with an edited one depending what you want to install.

So in life it backs up the original and replaces with a copy of the original but with the needed edits in.

[picaron]

This conversation begins to border on the absurd.
I do not want to talk about MODS, or whether or not this is the correct thread, since this is the extension that makes the modifications in the core of phpBB.
Martin, thank you for your comments.
I am not criticizing the extension, on the contrary, I think it is a great job.
I have simply given my opinion and this is that in the first message of this thread there should be a reference to the package that should be used when updating the forum, which should be this:
https://www.phpbb.com/downloads/3.3/update
I would like to end this conversation here because I think there is no need for more.

[HaioPaio]

Hello martin
I'm a bit confused after having read that discussion and hope for some clarification.
Let's assume that I have the Editor extension installed and enabled, together with other dmzx extensions which rely on it.
Let's assume I do a phpbb update with the full package method. I would disable all extensions beforehand and carry out the upgrade e.g.from 3.3.3 to 3.3.4. After completion of the upgrade, I would enable alle extensions again.
Would this cause any Problems?
What would happen if I would not disable the extensions before I perform the phpbb upgrade via the full package method? Could this cause problems?

[dmzx]

Let's assume I do a phpbb update with the full package method. I would disable all extensions beforehand and carry out the upgrade e.g.from 3.3.3 to 3.3.4. After completion of the upgrade, I would enable alle extensions again.
Would this cause any Problems?

No if you do it like this not, but its allot of work like this.

The way I do it is to get the updated files when upgrading and upload those to the root.
Then all edits are taken and you dont have to disable/enable extensions.

[HaioPaio]

Thank you dmzx

What would happen if I would not disable the extensions before I perform the phpbb upgrade via the full package method? Could this cause problems?

I understood that the "updated files" method would be easy and safe. I just want to understand.

[dmzx]

Thank you dmzx

What would happen if I would not disable the extensions before I perform the phpbb upgrade via the full package method? Could this cause problems?

I understood that the "updated files" method would be easy and safe. I just want to understand.

If you upload clean files the edits in core files are deleted and will be errors for sure.

[HaioPaio]

Thanks for clarification. Seems to be important to understand that.
I got it.

[dmzx]

Thanks for clarification. Seems to be important to understand that.
I got it.

[SpIdErPiGgY]

Okay I need some help on how to replace php code with this ext.

So lets say in /includes/acp/acp_email.php I need to add $messenger->set_mail_html(true); below this code $messenger = new messenger($use_queue);


How can I do that?