3.2 & 3.3 Extensions Database 3.2 / 3.3 ⇒ Ultimate Points Extension

[SpIdErPiGgY]

Hello everyone, I see that you have a lot to do. I have been using the extension for a long time and find it very good, but I don't understand these errors. I took these pictures and hope you understand what I mean. My English isn't good enough to explain this. I hope you can help me.

Ultimate Points Extension

[Micha]

That doesn't work causes other errors

[Stine]

Hello,

phpbb3.3.15
phpVersion 8.4

Code: Select all

PHP Warning:  Undefined array key "POINTS_SEPARATOR_DECIMAL" in ext/dmzx/ultimatepoints/core/functions_points.php on line 339
PHP Warning:  Undefined array key "POINTS_SEPARATOR_THOUSANDS" in ext/dmzx/ultimatepoints/core/functions_points.php on line 339

Points transfer to a member.
After sending:

Code: Select all

[phpBB Debug] PHP Warning: in file /ext/dmzx/ultimatepoints/core/points_transfer_user.php on line 257: Undefined array key "NOTIFICATION_TRANSFER_SUCCES"

Code: Select all

ext/dmzx\ultimatepoints/core/points_transfer.php
        Zeile 230:                                 'points_notify_msg' => sprintf($this->user->lang['NOTIFICATION_TRANSFER_SUCCES'], $am, $this->config['points_name']),
 ext/dmzx\ultimatepoints/core/points_transfer_user.php
        Zeile 257:                                 'points_notify_msg' => sprintf($this->user->lang['NOTIFICATION_TRANSFER_SUCCES'], $am, $this->config['points_name']),

[SpIdErPiGgY]

dmzx , I hope you don't mind that I made some fixes and improvements...?

There were some PHP errors with PHP 8.3 ,8.4,and 8.5.
Also bank points where not set correctly in /ultimatepoints?mode=bank

I tested this, and can't find any more errors at the moment... These are some of the things I did:

Ultimate Points – Compatibility & Stability Update

This update focuses on improving compatibility with modern PHP versions and resolving multiple stability issues across the extension.

✔ PHP Compatibility

• Fully updated for PHP 8.2, 8.3, 8.4 and 8.5
• Resolved strict PHP warnings (undefined array keys, null handling, etc.)
• Improved overall code safety using modern PHP practices

🛠 Fixes

• Fixed "Trying to access array offset on false" errors
• Fixed multiple "Undefined array key" warnings (e.g. user_id, holding, YES_ACCOUNT)
• Resolved duplicate sql_freeresult() calls causing fatal mysqli errors
• Corrected incorrect conditional checks (= → ==)
• Fixed bank account detection logic (now properly checks user_id instead of value)
• Improved handling of missing database rows (safe defaults added)

🌍 Language Improvements

• Synchronized all language files (EN, FR, DE) with the Dutch (NL) master
• Added missing language keys across all languages
• Ensured consistent order and structure in all language files
• Added new keys:
  • YES_ACCOUNT
  • NO_ACCOUNT
  • POINTS_GROUP_TRANSFER_PM_POINTS
• Improved translations for clarity and consistency

✉ Messaging Improvements

• Enhanced group points transfer messages
• Now includes:
  • Action (Add / Remove / Set)
  • Amount of points transferred
• Improved formatting for better readability in private messages

🛡 Stability Improvements

• Added fallback handling for missing language entries
• Prevented crashes caused by empty or invalid database results
• Safer variable handling throughout the extension

📌 Notes

• No functional features were removed or altered
• All changes are focused on stability, compatibility, and correctness
• Extension remains fully compatible with phpBB 3.3.x

🚀 Result

• Cleaner, more stable extension
• No PHP warnings or fatal errors in tested scenarios
• Fully ready for modern PHP environments

ultimatepoints1.2.8.fixed.zip

[ssl]

It’s true that here they are not the kings of maintenance.

[eunaumtenhoid]

It would be interesting to have some new features, such as:

Increasing point gains by a percentage defined by groups, for example, group X earns 10% more points on their actions, group Y 5%.
Logs in ACP and MCP specific to the extension.
Option to limit points to a maximum value.
Option to give a gift to the person on each birthday.
The General Information panel could be editable to display the point rules we want, or at least display only those that give points.
When disabling a module in ACP, such as the lottery, the same module could be disabled in UCP.