GeneralHtlm5 validation fix

General information
Previous topicNext topic
User avatar

Topic Author
dmzx
Founder
Founder
Magic user status: Online
Posts: 5978
Joined: Jan 13th, '14, 20:45
    Windows 8 Firefox

Htlm5 validation fix

Post by dmzx »

Htlm5 validation has changed phpbb is behind in the times :lol:
Open styles/prosilver/template/overall_header.html
Find This may be a partial find and not the whole line (spaces may differ)

Code: Select all

<link href="{T_THEME_PATH}/responsive.css?assets_version={T_ASSETS_VERSION}" rel="stylesheet" media="all and (max-width: 700px), all and (max-device-width: 700px)">
In line find This is a partial match of a line for in-line operations

Code: Select all

media="all and (max-width: 700px), all and (max-device-width: 700px)
Replace with Replace the preceding lines with the following

Code: Select all

media="all and (max-width: 700px)
Thats the style now valid

Now for ext's
Open phpbb/template/twig/node/includecss.php
Find This may be a partial find and not the whole line (spaces may differ)

Code: Select all

->raw(' rel="stylesheet" type="text/css" media="screen, projection" />')
Replace with Replace the preceding lines with the following

Code: Select all

->raw(' rel="stylesheet" type="text/css" media="screen" />')
binance.com ;) try it!
User avatar

Bullseye
Users
Users
Magic user status: Offline
Posts: 60
Joined: Sep 21st, '15, 23:44
    Windows 7 Firefox

Re: Htlm5 validation fix

Post by Bullseye »

I was going to ask how to do this... don't need to now, thanks for putting this up :dance:
Image
User avatar

Ascareus Kratos
Users
Users
Magic user status: Offline
Posts: 2
Joined: Feb 22nd, '15, 13:08
    Windows 10 Firefox

Re: Htlm5 validation fix

Post by Ascareus Kratos »

I wonder if phpbb notice this... :eyes2:
User avatar

martin
Admin
Admin
Magic user status: Online
Posts: 4844
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Htlm5 validation fix

Post by martin »

Ascareus Kratos wrote:i wonder if phpbb notice this... :eyes2:

They know about it.
Use this to install an ext on your board no more ftp or path making.
Path too install this ext is ext/boardtools/upload
Download is here Make it easy for us to solve your issues
User avatar

Nully
Users
Users
Magic user status: Offline
Posts: 111
Joined: Sep 8th, '15, 10:29
    Windows 7 Firefox

Re: Htlm5 validation fix

Post by Nully »

Thanks. Now W3C tells me its good :D
User avatar

Bullseye
Users
Users
Magic user status: Offline
Posts: 60
Joined: Sep 21st, '15, 23:44
    Windows 7 Firefox

Re: Htlm5 validation fix

Post by Bullseye »

Not sure if I have done it correctly but, I done the edits in overall_header.html, but the include.css file appeared to already have the edit suggested in this topic... here are the results :/

Showing results for http://bullbreedforum.net/index.php - Nu Html Checker
User avatar

martin
Admin
Admin
Magic user status: Online
Posts: 4844
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Htlm5 validation fix

Post by martin »

Includecss.php not include.css there is 2 files with almost the same name in phpbb/template/twig/node/
User avatar

Bullseye
Users
Users
Magic user status: Offline
Posts: 60
Joined: Sep 21st, '15, 23:44
    Linux Chrome

Re: Htlm5 validation fix

Post by Bullseye »

Includecss is the one I edited, it was a typo in the message lol

Code: Select all

<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/

namespace phpbb\template\twig\node;

class includecss extends \phpbb\template\twig\node\includeasset
{
	/**
	* {@inheritdoc}
	*/
	public function get_definition_name()
	{
		return 'STYLESHEETS';
	}

	/**
	* {@inheritdoc}
	*/
	public function append_asset(\Twig_Compiler $compiler)
	{
		$compiler
			->raw("<link href=\"' . ")
			->raw("\$asset_file . '\"")
			->raw(' rel="stylesheet" type="text/css" media="screen" />')
		;
	}
}
Last edited by Bullseye on Sep 24th, '15, 22:21, edited 1 time in total.
Previous topicNext topic