3.1.x Extensions Database 3.1 / 3.2[RC] Tables bbCode

<span class="qte-attr qte_31_32-qte">3.1.x &amp; 3.2.x</span>
User avatar

Puchahawa
Users
Users
Posts: 193
Joined: 20 Jun 2015, 17:58
    Windows 7 Chrome

Re: [RC] Tables bbCodes

Post by Puchahawa »

The version makes sense to me. Consistent with what is out in the public. :thumbup:

Did notice a few minor editing issues in the tables.php file. col 2 table 22 missing all th = left elements. col 5 table 53 and 59 same.

Anyone using this will need to edit the code of the tables that are already out there. Minor price for all the flexibility built in. :whistl: :tumbsyes:
th change.png
You do not have the required permissions to view the files attached to this post! Maybe your post count is too low.

User avatar

Topic Author
Sniper_E
VIP
VIP
Posts: 1157
Joined: 14 Oct 2014, 19:01
    Windows 10 Firefox

Re: [RC] Tables bbCodes

Post by Sniper_E »

I think those with 2.0.6 will have to delete a few of their bbcodes on updating. I wish install would allow updating existing bbcodes on enable.
I think we use to write it to do that in the mods.

From your image it looks like your th= bbcode didn't update. Repairs made uploading in a minute. Thanks! :thumbup:

Oh that is your old posts in that image. yea...
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!™

User avatar

proavia
Users
Users
Posts: 65
Joined: 30 Aug 2015, 22:50
    Android Chrome

Re: [RC] Tables bbCodes

Post by proavia »

Yeah - it's probably best to manually delete all the bbcodes associated with the Tables extension before updating to a newer version. Better safe than sorry - and will help keep support request down too. :eusa_dance:

I'll install the latest release tomorrow and test it out.

[ Post made via Android ] Image

User avatar

Puchahawa
Users
Users
Posts: 193
Joined: 20 Jun 2015, 17:58
    Windows 7 Chrome

Re: [RC] Tables bbCodes

Post by Puchahawa »

Figured I was in 3.2 rc1 test board so I would check this one too. :whistl:

Loads fine. Everything works as desired including the guidelines. Problem is, the code doesn't seem to parse. When you hit submit it just shows all the code. Pic is source code for the page the table is on.
3.2 rc1 table.png
You do not have the required permissions to view the files attached to this post! Maybe your post count is too low.

User avatar

proavia
Users
Users
Posts: 65
Joined: 30 Aug 2015, 22:50
    Windows 7 Internet Explorer

Re: [RC] Tables bbCodes

Post by proavia »

In 3.1.10..... IE and Chrome. Have a look at the Preview of the code below. Not an issue at all for me, just letting you know. I always use the Preview anyway so I can edit if needed.

Code: Select all

Default 2x4
[size=130]Table Title[/size]
[table=30 null][thead][tr=null][th=50 left]Title1[/th][th=50 left]Title2[/th][/tr][/thead]
[tbody][tr=bg2][td]Text11[/td][td]Text21[/td][/tr]
[tr=bg1][td]Text12[/td][td]Text22[/td][/tr]
[tr=bg2][td]Text13[/td][td]Text23[/td][/tr]
[tr=bg1][td]Text14[/td][td]Text24[/td][/tr][/tbody][/table]

All centered 2x4 - notice the extra line feed after "Table Title" in preview
[align=center][size=130]Table Title[/size][/align]
[align=center][table=30 tcenter][thead][tr=null][th=50 center]Title1[/th][th=50 center]Title2[/th][/tr][/thead]
[tbody][tr=bg2][td]Text11[/td][td]Text21[/td][/tr]
[tr=bg1][td]Text12[/td][td]Text22[/td][/tr]
[tr=bg2][td]Text13[/td][td]Text23[/td][/tr]
[tr=bg1][td]Text14[/td][td]Text24[/td][/tr][/tbody][/table][/align]

All centered 2x4 - same code as above, but removed LF after the "Table Title" line
[align=center][size=130]Table Title[/size][/align][align=center][table=30 tcenter][thead][tr=null][th=50 center]Title1[/th][th=50 center]Title2[/th][/tr][/thead]
[tbody][tr=bg2][td]Text11[/td][td]Text21[/td][/tr]
[tr=bg1][td]Text12[/td][td]Text22[/td][/tr]
[tr=bg2][td]Text13[/td][td]Text23[/td][/tr]
[tr=bg1][td]Text14[/td][td]Text24[/td][/tr][/tbody][/table][/align]

User avatar

Topic Author
Sniper_E
VIP
VIP
Posts: 1157
Joined: 14 Oct 2014, 19:01
    Windows 10 Chrome

Re: [RC] Tables bbCodes

Post by Sniper_E »

Puchahawa wrote: 05 Nov 2016, 23:09 Figured I was in 3.2 rc1 test board so I would check this one too. :whistl:
Loads fine. Everything works as desired including the guidelines. Problem is, the code doesn't seem to parse. When you hit submit it just shows all the code. Pic is source code for the page the table is on.
I just got 3.2 installed so I'll check the parsing smilie image name problem. It may need updating for 3.2
proavia wrote: 06 Nov 2016, 03:26 In 3.1.10..... IE and Chrome. Have a look at the Preview of the code below. Not an issue at all for me, just letting you know. I always use the Preview anyway so I can edit if needed.
I'll try those codes and preview see what it does. You mean, even if you had a new line after preview it jumps up a line in your textarea? Not sure that could be controlled. Preview is in charge there. I'll check that out.

User avatar

proavia
Users
Users
Posts: 65
Joined: 30 Aug 2015, 22:50
    Windows 7 Internet Explorer

Re: [RC] Tables bbCodes

Post by proavia »

Sniper_E wrote: 06 Nov 2016, 04:04
proavia wrote: 06 Nov 2016, 03:26 In 3.1.10..... IE and Chrome. Have a look at the Preview of the code below. Not an issue at all for me, just letting you know. I always use the Preview anyway so I can edit if needed.
I'll try those codes and preview see what it does. You mean, even if you had a new line after preview it jumps up a line in your textarea? Not sure that could be controlled. Preview is in charge there. I'll check that out.
Look at the 2nd and 3rd tables in preview. In the second, when centering the body rows/columns, the "Table Title" and the table are separated by an extra vertical space. In the 3rd table, I removed the LF between the [/align] (Table Title centering end) and the [align=...] (table body content centering). The 1st table was to show it doesn't do that if not centering the table body text.

Like I said, not a big issue at all. And some may want that space anyway. In any case, that's what Preview is for - look/edit before Submit.

User avatar

Topic Author
Sniper_E
VIP
VIP
Posts: 1157
Joined: 14 Oct 2014, 19:01
    Windows 10 Chrome

Re: [RC] Tables bbCodes

Post by Sniper_E »

Oh I see what you're saying. I guess wrapping other bbcodes around another bbcode has it's effects.

That's why it will be important to Preview before Submit, Adjust, Preview and Submit. You are creating the final results.

User avatar

proavia
Users
Users
Posts: 65
Joined: 30 Aug 2015, 22:50
    Android Chrome

Re: [RC] Tables bbCodes

Post by proavia »

Well, not actually wrapping one within another there. But yes, something with one after the other. IIRC, I saw those issues with phpbb 2.0 (yeah - 2.0) in some test with lots of bbcode. In that version, I think the Tables were included in ABBC.

Yeah - I use that preview button so much, I'm surprised I haven't worn it out. :rolling:

[ Post made via Android ] Image

User avatar

Topic Author
Sniper_E
VIP
VIP
Posts: 1157
Joined: 14 Oct 2014, 19:01
    Windows 10 Firefox

Re: [RC] Tables bbCodes

Post by Sniper_E »

I was wondering if the [td]s in tables needed some control like...
[td={IDENTIFIER}]{TEXT}[/td] == <td class="{IDENTIFIER}">{TEXT}</td>
Never know when you would want a certain block to stand out.

User avatar

proavia
Users
Users
Posts: 65
Joined: 30 Aug 2015, 22:50
    Windows 7 Internet Explorer

Re: [RC] Tables bbCodes

Post by proavia »

Would those classes be defined in the style used already or defined within the tables extension?

Just wondering - I kinda get where you're going with this. Maybe a more specific example would help me grasp it better (or not :rolling: ).

User avatar

Topic Author
Sniper_E
VIP
VIP
Posts: 1157
Joined: 14 Oct 2014, 19:01
    Windows 10 Firefox

Re: [RC] Tables bbCodes

Post by Sniper_E »

The default class in all of the [td=null] will be .null so it wouldn't change anything.

But for those specific cells you want some extra css for it to stand out... you add a class in the tables.css and use that class.
Right now the [tr=bg2] controls the background clear across the row in all the [td]s of that row.

Do each [td] or a certain [td] in that row need to have a class if you want to align them different?
Some align center, some align left, some with different bg or hover effect, anything.

Right now the [tr=bg2] sets all the [td] properties in a row. The individual [td]s have no control of their own. That's all.
Maybe it's fine without that.

User avatar

proavia
Users
Users
Posts: 65
Joined: 30 Aug 2015, 22:50
    Android Chrome

Re: [RC] Tables bbCodes

Post by proavia »

Ok, now I get it. So I could do most anything with that particular cell, as long as a custom class exists in the tables.css

I'm not sure how much I, personally, would actually use it. But having it there would add a bit more icing on the cake. How much of a hassle is it to add this?

I still haven't had time to add the custom background color class for the entire table. This is something I need for my site - probably not overly useful for most others. I plan on using the code and advice you provided in an earlier post.

[ Post made via Android ] Image

User avatar

Topic Author
Sniper_E
VIP
VIP
Posts: 1157
Joined: 14 Oct 2014, 19:01
    Android Chrome

Re: [RC] Tables bbCodes

Post by Sniper_E »

Yea Puchahawa's aero black style had to have a background color added to it in the tables.css classes. His style's .forabg class had no background. Your custom style may need that also.

The .tbg class is what I have in the table.css to add background or any thing else. I also have the .tables1 class in there, I need to remove one. We don't need two special tables classes in there.

Your old posts will mess up but you can fix them.
But I think the [td]s need some control if ever needed.

I'll add that and we should be good all around.

[ Post made via Samsung Galaxy S5 Active ] Image

User avatar

proavia
Users
Users
Posts: 65
Joined: 30 Aug 2015, 22:50
    Android Chrome

Re: [RC] Tables bbCodes

Post by proavia »

I use prosilver SE. But have some custom colors for text and a few other items. The standard background colors of prosilver show just fine in the tables. However, I do have the need for a custom background color for the entire table body from time to time.

Not worried about the old tables. I'm using your extension on a 3.1 development site. My live forum is still on 3.0 - which I plan on upgrading to 3.1 after I complete testing of a few other extensions and finish editing the theme css (I'd be done with the css if I knew what I was doing - but I'm learning as I go.... slowly.... with a lot of :wall: :wall: :wall: ).

Looking forward to your next- and hopefully - final, final RC. :tumbsyes:

[ Post made via Android ] Image

Post Reply Previous topicNext topic