3.1.x Extensions Database 3.1 / 3.2 ⇒ [RC] Tables bbCode

[Sniper_E]

I noticed the hover title on the button was not changing from 'Show Table Guidelines' to 'Hide Table Guidelines'

Hover over the button and it will show 'Show Table Guidelines' in the title.
Click it to show the guidelines.
Then hover over the button again and it should show 'Hide Table Guidelines' in the title.

I have the templates fixed for that and I trimmed down the css.
I'm now using each buttons ext classes for the buttons instead of the table classes.
But the only one I'm having problems with is the abbc3 title on hover in the acp.

First post updated with these changes. Same version 2.0.6
Grab that if you would and just replace the theme/ and template/ directory files. Clear cache. Refresh browser.

It is baffling me why I can't get that one title to change in the abbc3 acp. All the others work fine.
Please check and see if you have the same issue.

[Puchahawa]

Updated those directories and tested. Working as desired. show and hide.

[Sniper_E]

Cool I must have something stuck in my cache or something.
I'll check it on a fresh phphbb install to confirm that. That should resolve my issue.
Nothing I do corrects the problem on the title change. One more test and this ext is done.

[Sniper_E]

Oooops I had a tables filename wrong in that last package for the posting buttons ext. Easy fix on that.

But on a fresh install of phpbb and all these extensions...
After clicking the button on 'Show Table Guidelines' I still get a 'Show Table Guidelines' title on hover in abbc3. WTF

[Puchahawa]

That's bizarre! Maybe try a different browser or??

Maybe the answer is in this. Just looked at mine again. In the normal post a topic area it's show and hide. But in the ACP I'm getting show and show.

[Sniper_E]

That is bizarre! I just tried another browser. Why didn't I think of doing that.

Same thing. I might have to [ABD] this ext.

This function below is toggling the id #table_guide display but it is not toggling the id #table-img title.

Code: Select all

		<script>
			function toggle_table_guide()
			{
				var x = document.getElementById('table_guide');
				if (x.style.display === 'block') { x.style.display = 'none';document.getElementById('table-img').title = '{L_TABLES_BBCODE_HELP}'; }
				else { x.style.display = 'block';document.getElementById('table-img').title = '{L_TABLES_BBCODE_HIDE_HELP}'; }
			}
		</script>

		<span class="tables">
			<input type="button" class="abbc3_button" name="table_guide" id="table-img" value="" onclick="toggle_table_guide();" title="{L_TABLES_BBCODE_HELP}" />

Why?

[Puchahawa]

In looking at a few of the template html files the order of show and hide in the <script> function toggle_table_guide() definition is different. Some are show then hide. Some are hide then show.

Don't know if that would make any difference or not but it got my attn.

[Sniper_E]

In the normal post a topic area it's show and hide. But in the ACP I'm getting show and show.

Exactly! That's what I was saying. Only in the acp for abbc3 buttons does it show that, show/show

In posting it does a show/hide title without buttons ext and with both buttons ext.
In the acp only the abbc3 buttons shows the show/show. In acp without buttons ext and with posting buttons all works well.

Let me look at those templates you're talking about.

Look at the one I posted above.

Code: Select all

if (x.style.display === 'block')
else { x.style.display = 'block';

They both say block. You did it, you found my problem. Copy and paste will kick your butt sometimes.
Give me a minute to fix these templates.

EDIT: No that code is correct. Shit!

[Sniper_E]

Well I fixed the function codes in all the templates to be the same but I still have the same problem.
Maybe I can come back to it later and look for what I'm missing. It makes no sense.

Download on first post is updated with my latest edits.

I have to walk away from this thing now.

[Puchahawa]

Before I say this I need a disclaimer. I know enough to get myself into trouble.

Looking at the two html files for ABBC3 in win merge and the only difference is the <span class="row3 table-selections"> in ACP and <span class="bg2 table-selections"> in "normal post area. Is that difference just what class needs to be used for the ACP vs normal post area?

I did notice that in image b vs abbc3 the class is bg1 ???

[Puchahawa]

Just looked at the latest edit you did. Making it all the same. IT WORKED. Show and hide in BOTH for ABBC3

did a disable / delete data. remove table bbcodes / purge cache and enable of latest.

Checking on my other test board now. That's confusing. it's still show/show. same version of abbc3 and tables as the other board. purged cache. Using chrome. going to check with other browsers now. Checked with ie and FF Same issue. it works acp and post page on one board and only on post page in the other. Interestingly it's a relatively new install of 3.1.9 that isn't working correctly. Same files though.

Tried my live board. disable / delete data / remove all bbcodes manually / purged cache/ remove old files / add new / activate. WORKS correctly.

So I'm 2 for 3 working as desired. Don't get why the one local board won't get it.

[Sniper_E]

Looking at the two html files for ABBC3 in win merge and the only difference is the <span class="row3 table-selections"> in ACP and <span class="bg2 table-selections"> in "normal post area.

Yes in the acp the admin.css uses row3 and row4. In the forum the colours.css uses bg1 and bg2.
That is the reason I had to create two different templates. I used the lighter color background colors in each.

So I'm 2 for 3 working as desired. Don't get why the one local board won't get it.

Yes my three test sites I'm using are on the same server, same site with different directories. Maybe that has something to do with it.
The two sites where it worked right for you must be on different sites by themselves. No other test sites on the same server. Yes

Maybe my codes are fine and they conflict when testing on multiple sites on the same server.
From these tests we have been doing that is what it seems like to me. Thank you for your time with those tests.

If multiple sites on the same server is not causing this problem then I have no clue. You think we found the problem

I'll change the id name on one of mine and see if the conflict is corrected.

[Puchahawa]

I just don't know. My two test sites are (local wampserver) Same server. The board that works is in directory called phpbb12. The one not working is phpbb3. Both in the same server root (www)

So one of those works and my live board hosted in canada works in dir called phpbb3.

[Sniper_E]

I'm changing the function name and the id names in each of the templates to see if that is the conflict. Tests look promising.

I'll update here in a minute...

[Sniper_E]

OK looks like that was the problem. Each template has it's own function and id name. We have a winner

First post updated with the final version download.