3.1.x SnippetsCollapse in 3.1.x

Snippets
User avatar

Sniper_E
VIP
VIP
Status: Offline
User theme: Dark
Posts: 1151
Joined: Oct 14th, '14, 17:01
    Windows 8.1 Firefox

Re: Collapse in 3.1.x

Post by Sniper_E »

Does your custom style have a forumlist_body.html template?
Does your custom style have a overall_footer.html template?
Does your custom style have a common.css stylesheet?

Do all edits to your custom style the same as you would do the prosilver edits.

The instructions on the first post are very simple and detailed. That guide gets no better.
I think others in this topic has this working on their site. You have to be not doing something. Check yourself.

EDIT

Dude, I just went to your site again and looked at your source codes and the scripts are not in the footer.
It looks like you are not doing anything as far as adding codes in your templates. I can see your codes.
What are you doing man? You are wasting my time trying to help you.
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!™
User avatar

deepndark
Users
Users
Status: Offline
User theme: Dark
Posts: 9
Joined: Jan 17th, '15, 17:24
    Windows 7 Firefox

Re: Collapse in 3.1.x

Post by deepndark »

I deleted all the codes, they were there before. I just may give it a one more try.
Anyway, the guide is misleading, because the OP didn't tell to put the codes to the other styles as well. (it only said to use those codes for Prosilver).
User avatar

Sniper_E
VIP
VIP
Status: Offline
User theme: Dark
Posts: 1151
Joined: Oct 14th, '14, 17:01
    Windows 8.1 Firefox

Re: Collapse in 3.1.x

Post by Sniper_E »

The bottom line is that I hope you got it working. I'm sorry you had all those problems.

But deepndark, all mod instructions list prosilver edits and they use to list subsilver2 edits only.
All custom styles that are prosilver base styles, use the prosilver edits to their custom style.

Inheriting templates from the prosilver style is a common thing also. But not everything is inherited.
If a custom prosilver based style has a template it uses it's template. If not it inherits prosilver's template.

Are you good deepndark? You got this? Halla... I'd like to see you concur this. :thumbup:
User avatar

martin
Admin
Admin
Status: Offline
User theme: Dark
Posts: 5060
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Collapse in 3.1.x

Post by martin »

The code in the first post is prosilver only if you want subsilver then your on your own.

CorradoG60.com
Status: Offline
User theme: Dark
    Windows 7 Chrome

Re: Collapse in 3.1.x

Post by CorradoG60.com »

I can't get this to work :sad:

I tried redoing it three times, but each time I had half of my forums outside of my #wrap and I don't know why. I have made some small changes to the core files so maybe it's because of that...It also caused around 30 errors in the W3 validator because of <divs> being placed within <ul> or something...Perhaps spans would be better?

Currently removed it as the board is live/active.
User avatar

martin
Admin
Admin
Status: Offline
User theme: Dark
Posts: 5060
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Collapse in 3.1.x

Post by martin »

Then you did it wrong you are using prosilver ?

demo of it in action Blades-place - Index page

I see you have just a few more edits than a few on your site :lol:

CorradoG60.com
Status: Offline
User theme: Dark
    Windows 7 Chrome

Re: Collapse in 3.1.x

Post by CorradoG60.com »

Yep, prosilver...Just with some CSS changes etc :whistl:

I definitely followed the instructions perfectly, but it just doesn't seem to work on my site. :sad: Shame but I may have another go sometime...
User avatar

martin
Admin
Admin
Status: Offline
User theme: Dark
Posts: 5060
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Collapse in 3.1.x

Post by martin »

I'v not tested or looked yet but the code in the first post was for 3.1.1 there may well be some changes as i'm in the uk and its late il test this out in the morning.
User avatar

martin
Admin
Admin
Status: Offline
User theme: Dark
Posts: 5060
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Collapse in 3.1.x

Post by martin »

Small fix in the css file
Find This may be a partial find and not the whole line

Code: Select all

z-index: 9998;
Replace with Replace the preceding lines with the following

Code: Select all

z-index: 2;
Now the collapse icon wont show up on the footer bar.
User avatar

Topic Author
dmzx
Founder
Founder
Status: Offline
User theme: Dark
Posts: 6365
Joined: Jan 13th, '14, 20:45
    Windows 8 Firefox

Re: Collapse in 3.1.x

Post by dmzx »

martin wrote:Small fix in the css file
Find This may be a partial find and not the whole line

Code: Select all

z-index: 9998;
Replace with Replace the preceding lines with the following

Code: Select all

z-index: 2;
Now the collapse icon wont show up on the footer bar.

:thumbup:

CorradoG60.com
Status: Offline
User theme: Dark
    Windows 7 Chrome

Re: Collapse in 3.1.x

Post by CorradoG60.com »

Still can't get this to work :sad:

The first category can collapse/expand, but none of the others work. And also half of my categories get placed outside of the #wrap.

Here is my forumlist_body.html, I've done exactly as suggested.

Code: Select all

<!-- <div class="xmas"></div> ABOVE FORABG --><div class="forumlist"><!-- BEGIN forumrow -->
<!-- IF (forumrow.S_IS_CAT and not forumrow.S_FIRST_ROW) or forumrow.S_NO_CAT  -->
</ul>
</div>
</div>
</div><!-- ENDIF -->

<!-- EVENT forumlist_body_category_header_before -->
<!-- IF forumrow.S_IS_CAT or forumrow.S_FIRST_ROW or forumrow.S_NO_CAT  -->
<div class="forabg">
<div class="inner">
	<ul class="topiclist">
		<li class="header">
		<dl class="icon">
		<dt><div class="list-inner"><!-- IF forumrow.S_IS_CAT --><a href="{forumrow.U_VIEWFORUM}" title="{forumrow.FORUM_NAME}">{forumrow.FORUM_NAME}</a><!-- ELSE -->{L_FORUM}<!-- ENDIF --></div></dt>
		<dd class="topics">{L_TOPICS}</dd>
		<dd class="posts">{L_POSTS}</dd>
		<dd class="lastpost"><span>{L_LAST_POST}</span></dd>
		</dl>
	</li>
</ul>
<ul class="topiclist forums"><!-- IF SCRIPT_NAME eq 'index' --><div class="trigger active"></div><!-- ENDIF -->
            <div class="collapsethis"><!-- ENDIF -->
	<!-- EVENT forumlist_body_category_header_after -->

	<!-- IF not forumrow.S_IS_CAT -->
		<!-- EVENT forumlist_body_forum_row_before -->
	<li class="row"<!-- IF forumrow.FORUM_ID eq '50' --> style="background-color:#E7E7E7/*ECD5D8*/;"<!-- ENDIF -->>
			<!-- EVENT forumlist_body_forum_row_prepend -->
			<dl class="icon {forumrow.FORUM_IMG_STYLE}">
			<!-- MODDED FONTAWESOME <dl class="icon">
            <dd class="fa-forum-icon {forumrow.FORUM_IMG_STYLE}"></dd> -->
				<dt title="{forumrow.FORUM_FOLDER_IMG_ALT}">
<!-- IF forumrow.S_UNREAD_FORUM --><a href="{forumrow.U_VIEWFORUM}" class="icon-link"></a><!-- ENDIF -->
					<div class="list-inner">
						<!-- IF S_ENABLE_FEEDS and forumrow.S_FEED_ENABLED --><!-- <a class="feed-icon-forum" title="{L_FEED} - {forumrow.FORUM_NAME}" href="{U_FEED}?f={forumrow.FORUM_ID}"><img src="{T_THEME_PATH}/images/feed.gif" alt="{L_FEED} - {forumrow.FORUM_NAME}" /></a> --><!-- ENDIF -->

<!-- IF forumrow.FORUM_IMAGE --><span class="forum-image">{forumrow.FORUM_IMAGE}</span><!-- <span class="forum-image"><img src="./images/welcome.png" width="56" height="44" alt="Welcome to the Corrado G60 Forum"></span> --><!-- ENDIF -->
						<a href="{forumrow.U_VIEWFORUM}" class="forumtitle" title="{forumrow.FORUM_NAME}"<!-- IF forumrow.S_IS_LINK --> target="_blank"<!-- ENDIF -->>{forumrow.FORUM_NAME}</a>
				<!-- IF forumrow.FORUM_DESC --><br />{forumrow.FORUM_DESC}<!-- ENDIF -->
						<!-- IF forumrow.MODERATORS -->
	<br /><strong>{forumrow.L_MODERATOR_STR}{L_COLON}</strong> {forumrow.MODERATORS}<!-- ENDIF -->
						<!-- IF .forumrow.subforum and forumrow.S_LIST_SUBFORUMS -->
						<!-- EVENT forumlist_body_subforums_before -->
					<hr /><!-- modded -->{forumrow.L_SUBFORUM_STR}{L_COLON}
							<!-- BEGIN subforum -->
<a href="{forumrow.subforum.U_SUBFORUM}" class="subforum<!-- IF forumrow.subforum.S_UNREAD --> unread<!-- ELSE --> read<!-- ENDIF -->" title="<!-- IF forumrow.subforum.UNREAD -->{L_UNREAD_POSTS}<!-- ELSE -->{L_NO_UNREAD_POSTS}<!-- ENDIF -->">{forumrow.subforum.SUBFORUM_NAME}</a><!-- IF not forumrow.subforum.S_LAST_ROW -->{L_COMMA_SEPARATOR}<!-- ENDIF -->
	<!-- END subforum -->
		<!-- EVENT forumlist_body_subforums_after -->
		<!-- ENDIF -->

		<!-- IF not S_IS_BOT -->
			<div class="responsive-show" style="display: none;">
				<!-- IF forumrow.CLICKS -->
				{L_REDIRECTS}{L_COLON} <strong>{forumrow.CLICKS}</strong>
				<!-- ELSEIF not forumrow.S_IS_LINK and forumrow.TOPICS -->
			{L_TOPICS}{L_COLON} <strong>{forumrow.TOPICS}</strong><!-- ENDIF -->
			</div><!-- ENDIF -->
					</div>
				</dt>
				<!-- IF forumrow.CLICKS -->
			<dd class="redirect"><span>{L_REDIRECTS}{L_COLON} {forumrow.CLICKS}</span></dd>
				<!-- ELSEIF not forumrow.S_IS_LINK -->
					<dd class="topics">{forumrow.TOPICS} <dfn>{L_TOPICS}</dfn></dd>
					<dd class="posts">{forumrow.POSTS} <dfn>{L_POSTS}</dfn></dd>
					<dd class="lastpost"><span>
						<!-- IF forumrow.U_UNAPPROVED_TOPICS -->
					<a href="{forumrow.U_UNAPPROVED_TOPICS}">{UNAPPROVED_IMG}</a>
						<!-- ELSEIF forumrow.U_UNAPPROVED_POSTS -->
		<a href="{forumrow.U_UNAPPROVED_POSTS}">{UNAPPROVED_POST_IMG}</a><!-- ENDIF -->
						<!-- IF forumrow.LAST_POST_TIME --><dfn>{L_LAST_POST}</dfn>
						<!-- IF forumrow.S_DISPLAY_SUBJECT -->
						<!-- EVENT forumlist_body_last_post_title_prepend -->
<a href="{forumrow.U_LAST_POST}" title="{forumrow.LAST_POST_SUBJECT}" class="lastsubject">{forumrow.LAST_POST_SUBJECT}</a> <br /><!-- ENDIF --> 
						{L_POST_BY_AUTHOR} {forumrow.LAST_POSTER_FULL}
<!-- IF not S_IS_BOT --><!-- IF SCRIPT_NAME neq 'index' --><a href="{forumrow.U_LAST_POST}">{LAST_POST_IMG}</a><!-- ENDIF --><!-- ENDIF --><br />{forumrow.LAST_POST_TIME}<!-- ELSE -->{L_NO_POSTS}<br />&nbsp;<!-- ENDIF --></span>
					</dd>
				<!-- ELSE -->
					<dd>&nbsp;</dd>
				<!-- ENDIF -->
			</dl>
			<!-- EVENT forumlist_body_forum_row_append -->
		</li>
		<!-- EVENT forumlist_body_forum_row_after -->
	<!-- ENDIF -->

	<!-- IF forumrow.S_LAST_ROW -->
	</div>
			</ul>
			</div>
		</div>
	<!-- EVENT forumlist_body_last_row_after -->
	<!-- ENDIF -->

<!-- BEGINELSE -->
	<div class="panel">
		<div class="inner">
		<strong>{L_NO_FORUMS}</strong>
		</div>
	</div>
<!-- END forumrow -->
</div>
snippy1.png
You do not have the required permissions to view the files attached to this post! Maybe your post count is too low.
User avatar

martin
Admin
Admin
Status: Offline
User theme: Dark
Posts: 5060
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Collapse in 3.1.x

Post by martin »

Volkswagen Corrado G60 Owners Forum is collapsing fine clear your browser

Image
Last edited by martin on Mar 4th, '15, 23:02, edited 1 time in total.

CorradoG60.com
Status: Offline
User theme: Dark
    Windows 7 Chrome

Re: Collapse in 3.1.x

Post by CorradoG60.com »

Yeah, but I've had to leave out the </div> from this code block below
dmzx wrote:
Open: /styles/prosilver/template/forumlist_body.html
Find This may be a partial find and not the whole line

Code: Select all

<!-- IF (forumrow.S_IS_CAT and not forumrow.S_FIRST_ROW) or forumrow.S_NO_CAT  -->
            </ul>
Add after Add these lines on a new blank line after the preceding line(s) to find

Code: Select all

</div>
And now I get lots of errors in IE's inspector :sad: and also w3 [Invalid] Markup Validation of http://www.corradog60.com/ - W3C Markup Validator

EDIT: I also checked the source of this site, and it doesn't have the coding the same as shown in the first post of this topic, it passes validation, so the first post instructions must be wrong?
User avatar

martin
Admin
Admin
Status: Offline
User theme: Dark
Posts: 5060
Joined: Apr 6th, '14, 14:12
    Linux Chrome

Re: Collapse in 3.1.x

Post by martin »

Just loaded a fresh site and installed the collapse on 3.1.3 and works perfect test here yourdomain.com - Index page

so you have it conflicting with an ext or edit.

CorradoG60.com
Status: Offline
User theme: Dark
    Windows 7 Chrome

Re: Collapse in 3.1.x

Post by CorradoG60.com »

That doesn't validate either though, [Invalid] Markup Validation of http://www.blades-place.dyndns.info/test/index.php - W3C Markup Validator The coding isn't the same as this sites. Can admin pop up their forumlist_body.html so I can see the difference?

On here, it's coded differently - It works and passes validation.
On my site - It works with the code in first post if I leave a div out - But doesn't pass validation (Normally does)
The test link - also works but doesn't validate.

Goin to remove the code for now just in case you were having a look at my site.